[WIP] See if we can make symbolic values default#2795
Draft
Conversation
Needed for floordiv
Co-authored-by: riccardofelluga <riccardofelluga@users.noreply.github.com>
tested by test_set_grad_enabled
test: thunder/tests/test_core.py::test_integer_isinstance_mimicry
grad_transform_on_trace creates a cycle in the proxy names of tensor shapes. Specifically, it translates tA = prims.cat([tB, tC], -1) # "meta f32[..., iX]" (..., iX) = prims.shape(tA) into ta = prims.cat([tb, tc], -1) # "meta f32[..., ix]" (..., iX) = prims.shape(ta) This creates a translation ix -> iX. This leads to a cycle when the transform also produces iX -> ix. Repro: thunder/tests/test_jit_general.py::test_litgpt_variants[meta-long-context-like]
Fixes thunder/tests/test_grad.py::test_phantom_grad_vs_torch_consistency_var_mean_nvfuser_cuda_thunder.dtypes.float32
Collaborator
|
FYI: the intention for Q4 is to enable symbolic values for thunderfx, not for thunder.jit. |
…r into make-symbolic-default
shino16
force-pushed
the
make-symbolic-default
branch
from
af36fe7 to
b3a78f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see how many tests fail when we make
cache="symbolic values"the default option.I don't intend to merge this PR. Unmerged PRs and dirty commits are contained.